Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 9 years ago

#3194 closed enhancement (fixed)

Friends request acceptance

Reported by: ezd's profile ezd Owned by: dennissmolek's profile Dennissmolek
Milestone: 1.7 Priority: normal
Severity: normal Version:
Component: Friends Keywords:
Cc: Dennissmolek, karmatosed@…

Description

Hi,

When you get a friend request you get to choose between the two buttons "Reject" and "Accept" which is fine, but when you click the "Accept" button the button renames into a button called "Accepted". If you then click the "Accepted" button it gives a script error and nothing happens.

I suggest that after you click the "Accept" button you get a notification that the friend has been added to your friends list. Not a notification in the form of an "Accepted" button that really has no functionality!

Maybe the page should redirect to the friends page where you can see the friend has been added combined with a green bar notification that the friend has been added to your friend list.

It would be a start. I personally think the whole notification system should be drastically improved.

Attachments (2)

3194.01.patch (703 bytes) - added by Dennissmolek 11 years ago.
This removes the button class and the cursor, but it being a link it still has the hover. I could make a rejected or accepted class in the css as they already get attached.. ..
3194-2.patch (3.1 KB) - added by Dennissmolek 11 years ago.
Ok, way more in depth version. Creates a visit user link when accepted, and just grays out the rejected bar. The button isnt working directly for some reason, but will in a new tab. Ideas?

Download all attachments as: .zip

Change History (8)

#1 @DJPaul
11 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version 1.3 deleted

This area does need improvements but unlikely to get into 1.3 unless someone starts work on some design mockups and/or patches.

@Dennissmolek
11 years ago

This removes the button class and the cursor, but it being a link it still has the hover. I could make a rejected or accepted class in the css as they already get attached.. ..

@Dennissmolek
11 years ago

Ok, way more in depth version. Creates a visit user link when accepted, and just grays out the rejected bar. The button isnt working directly for some reason, but will in a new tab. Ideas?

#2 @Dennissmolek
11 years ago

  • Cc Dennissmolek added
  • Keywords has-patch added

#3 @DJPaul
11 years ago

I don't think trac sends email notifications when a file is attached, so always leave a friendly comment :)

#4 @Dennissmolek
11 years ago

  • Keywords needs-ui added
  • Owner set to Dennissmolek
  • Status changed from new to assigned

#5 @karmatosed
10 years ago

  • Cc karmatosed@… added
  • Keywords changed from has-patch, needs-ui to has-patch needs-ui
  • Severity set to normal

#6 @DJPaul
9 years ago

  • Keywords has-patch needs-ui removed
  • Milestone changed from Future Release to 1.7
  • Resolution set to fixed
  • Status changed from assigned to closed

I'm not sure when this was fixed, so marking as 1.7 as most recent. What happens now is that the button disappears and the plain text words "Accepted" appears.

Note: See TracTickets for help on using tickets.