Skip to:
Content

Opened 8 years ago

Closed 8 years ago

#3178 closed defect (bug) (fixed)

Don't show BP-Wizard permalinks panel if we have pretty permalinks

Reported by: cnorris23 Owned by:
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Core Keywords: has-patch
Cc:

Description

During a new installation of BP, the permalinks panel is shown regardless of whether or not pretty permalinks are already in use. This can cause confusion if the user already has them set.

Attachments (3)

3178.001.diff (3.4 KB) - added by cnorris23 8 years ago.
3178.002.diff (3.3 KB) - added by cnorris23 8 years ago.
3178.003.diff (3.8 KB) - added by cnorris23 8 years ago.

Download all attachments as: .zip

Change History (13)

@cnorris23
8 years ago

#1 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to 1.3
  • Owner set to DJPaul
  • Status changed from new to assigned

Nice idea

#2 @cnorris23
8 years ago

The $wp_rewrite global is already there, so use that instead.

@cnorris23
8 years ago

#3 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4291]) Only show permalinks panel during install if not already in use. Fixes #3178, props cnorris23

#4 @djpaul
8 years ago

(In [4293]) Revert r4292:4290. See #3178

#5 @DJPaul
8 years ago

  • Keywords has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

I decided to revert this commit as it had the unintended consequence of making the "Permalinks" panel disappear after they were set in the install. This looked a bit jarring. A better solution would be to improve the text on the permalinks panel to make it clear that they've already been set. Most of the the upgrader screens' text need some love, so it's probably worth getting them in one go.

#6 @cnorris23
8 years ago

I remember running into this when I was doing something with the pages panel. Unfortunately, I can't remember how I fixed it. I'll play with it tonight, and if I can't come up with a solution that's not hacky, I'll write up a patch with alternate text.

@cnorris23
8 years ago

#7 @cnorris23
8 years ago

  • Keywords has-patch added

Finally got to this. I spent some time trying to figure something out, but there's no easy way that doesn't require a temporary database option or another cookie. It's just not worth all that. Besides, it can't hurt to give admins another chance to get the pretty permalinks of their dreams :)

#8 @DJPaul
8 years ago

  • Owner DJPaul deleted
  • Status changed from reopened to assigned

#9 @boonebgorges
8 years ago

+1 for this solution. I'm going to tweak the wording a bit and then throw 'er in there. Thanks, cnorris23.

#10 @boonebgorges
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4342]) Changes text on wizard Permalink panel to reflect whether user has already set permalinks. Fixes #3178. Props cnorris23

Note: See TracTickets for help on using tickets.