Skip to:
Content

Opened 8 years ago

Closed 3 years ago

Last modified 3 years ago

#3172 closed enhancement (fixed)

cancelling friendship via ajax should remove row from list

Reported by: DJPaul Owned by: Dennissmolek
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords: needs-patch needs-ui
Cc: Dennissmolek, georgemamadashvili@…, karmatosed@…, vivek@…

Description

When cancelling a friendship via ajax on /members/admin/friends/my-friends/, BuddyPress draws a "add friend" button. If you refresh the page, this cancelled friendship obviously disappears.

Whilst the "add friend" response adds a bit of a safety net in case a user misclicks, I think it harms the user experience. I don't expect to see an "add friend" button on a page which lists my current friends (especially just after telling the system to remove that relationship).

This would involve patching bp_dtheme_ajax_addremove_friend() and the javascript function in global.js, perhaps to slideUp() the row like what happens in the WordPress dashboard when you mark a comment as spam.

Attachments (1)

speechbubbles.jpg (30.0 KB) - added by karmatosed 8 years ago.

Download all attachments as: .zip

Change History (15)

#1 @Dennissmolek
8 years ago

I was recently testing something else and was adding/deleting fake users over and over. I think you are right about the person disappearing, but I think a "Are you Sure?" alert should be provided. Facebook has a popup, or we could simply create a text alert right next to the button that says "are you sure" and change the buttons text to "yes", and also give a "no" option. A pop up may be annoying, but it would limit misclicks and the embarrassing PM about accidentally deleting someone.

I am willing to work on this, but would like to know what would be preferred, a pop up or a inline alert.

#2 @Dennissmolek
8 years ago

  • Cc Dennissmolek added

#3 @DJPaul
8 years ago

  • Keywords needs-ui added

I think pop up windows are distracting and only work well in situations where the action takes place outside the context of the current site, such as external logins (OAUTH, iframes) or in an interaction flow for tasks like sharing links with link sharing services (twitter, reddit, etc). Then, when the action has completed, you close the pop up and you are back to your original website.

I think it is worthwhile to design some mockups so everyone can give feedback. There should be no reason why the ui/ux solution for this problem shouldn't be usable everywhere across a BuddyPress site, where relevant. For examples, on the "my groups" screens.

In 1.4, something that I think would be more elegant would be to have a safety period; that is, a 5 minute window where you can re-friend after cancelling a friendship, without starting the new request process (making use of the idea of Trashed items as in wp-admin).

Last edited 8 years ago by DJPaul (previous) (diff)

#4 @Dennissmolek
8 years ago

  • Owner set to Dennissmolek
  • Status changed from new to accepted

#5 @karmatosed
8 years ago

  • Severity set to normal

I'd strongly lean on the 'can we do this with a safe period' rather than a pop up of any form. That said perhaps we could even break the mould and consider something different to the usual pop ups. I once worked on a site that used speech bubbles rather than error messages or confirmation pop ups. This worked well weirdly making no UI impact users 'got it'.

I've attached a rough mock up of something we could consider it's a bit out there and certainly not a finished style but perhaps an alternative. The mockups (really sketchups) are speechbubbles.jpg

@Dennissmolek - are you working on mockups if not I can do some more traditional ones if you are busy?

#6 @DennisSmolek
8 years ago

With all the changes to the default theme I was waiting for it to settle before doing these future release tasks. The comment box is decent, but what happens if I click someone on accident? The pop up stays there? I have a time out? The box is still a pop up in the technical sense for an alert.
I dont care if its a bubble or just a div next to the button, but I think a "no" is a requirement.

I'll get some mock ups on here today

#7 @Mamaduka
7 years ago

  • Cc georgemamadashvili@… added

#8 @karmatosed
7 years ago

  • Cc karmatosed@… added

#9 @sooskriszta
5 years ago

  • Cc vivek@… added
  • Component changed from Theme to Template Pack

#10 @DJPaul
4 years ago

  • Component changed from Appearance - Template Pack to Appearance - Template Parts

#11 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates

#12 @DJPaul
3 years ago

@imath are you re-working this in BP Nouveau? If so, let's close this ticket because BP-Legacy etc etc. :)

#13 @imath
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

@DJPaul absolutely. In BP Nouveau, when clicking on the buttons "Accept" or "Reject" a status message confirms the action was taking in account and the row is fading out.

#14 @r-a-y
3 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.