Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 3 years ago

#3156 closed defect (bug) (fixed)

Allow child theme authors to override /_inc/ajax.php

Reported by: r-a-y Owned by:
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Templates Keywords: has-patch dev-feedback
Cc:

Description

Contrary to the comments in /_inc/ajax.php, it is currently not possible to override ajax.php in your child theme.

The attached patch fixes this, however I wouldn't recommend the general practice of overriding ajax.php as there's too much functionality built into bp-default; I'd just pick and choose the actions I'd want to override instead.

I'll leave it to the core devs to decide whether this should be included or not.

Attachments (2)

3156.01.patch (455 bytes) - added by r-a-y 8 years ago.
3156.02.patch (1.2 KB) - added by r-a-y 8 years ago.
Removes comment about overriding ajax.php in child theme; remove trailing whitespace

Download all attachments as: .zip

Change History (8)

@r-a-y
8 years ago

#1 @DJPaul
8 years ago

You'd need to check if the file existed, as it might not be in most child themes. I'm not sure if a file_exists or a apply_filters would be most appropriate here.

#2 @r-a-y
8 years ago

Yeah, maybe just remove the comment in ajax.php about overriding.

@r-a-y
8 years ago

Removes comment about overriding ajax.php in child theme; remove trailing whitespace

#3 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to 1.3

#4 @DJPaul
8 years ago

  • Keywords dev-feedback added

#5 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4354]) Remove misleading documentation from _inc/ajax.php. Fixes #3156, props r-a-y

#6 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.