Opened 15 years ago
Closed 15 years ago
#3148 closed enhancement (fixed)
BP_Core_User constructor not 5.3.3 >= friendly
| Reported by: | Backie | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.5 |
| Component: | Core | Version: | |
| Severity: | Keywords: | has-patch | |
| Cc: |
Description
In PHP 5.3.3 release the use of PHP 4 constructors would not longer be acceptable.
Solution for PHP 4 compatibly is to rename method to PHP 5 style and then have a PHP 4 constructor function which calls the PHP 5 method.
ps: Will patch once I finish the phpDocs
Attachments (3)
Change History (10)
#2
@
15 years ago
I've noticed another one in the same file BP_Core_Notification, started phpDocs so gonna wait until I finish that before I start auditing the other files if I have time. If not I'll do it tomorrow.
#3
@
15 years ago
- Keywords needs-patch added
- Milestone Awaiting Review → 1.3
A patch getting all of these would be great
#4
@
15 years ago
- Keywords has-patch added; needs-patch removed
Patch also fixes an incompatibly with WordPress 3.2 where class BPDB calls WPDB() as the parent constructor which has been removed.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
It probably wouldn't hurt to audit the other files to check for this. Unless of course you already have :) If you can't get to it, I'll try to whip something up tonight.