Opened 14 years ago
Closed 14 years ago
#3148 closed enhancement (fixed)
BP_Core_User constructor not 5.3.3 >= friendly
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 1.5 | Priority: | normal |
Severity: | Version: | ||
Component: | Core | Keywords: | has-patch |
Cc: |
Description
In PHP 5.3.3 release the use of PHP 4 constructors would not longer be acceptable.
Solution for PHP 4 compatibly is to rename method to PHP 5 style and then have a PHP 4 constructor function which calls the PHP 5 method.
ps: Will patch once I finish the phpDocs
Attachments (3)
Change History (10)
#2
@
14 years ago
I've noticed another one in the same file BP_Core_Notification, started phpDocs so gonna wait until I finish that before I start auditing the other files if I have time. If not I'll do it tomorrow.
#3
@
14 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 1.3
A patch getting all of these would be great
#4
@
14 years ago
- Keywords has-patch added; needs-patch removed
Patch also fixes an incompatibly with WordPress 3.2 where class BPDB calls WPDB() as the parent constructor which has been removed.
It probably wouldn't hurt to audit the other files to check for this. Unless of course you already have :) If you can't get to it, I'll try to whip something up tonight.