BP_Core_User::$total_blogs

[Backie]

I'm phpDoc'ing BP_Core_User and noticed $total_blogs isn't used, I suspect it should be getting populated during the BP_Core_User::populate_extras() call.

Since I am not sure if there is a pre-made function to fetch this data I haven't made a patch.

[DJPaul]

That dates from BuddyPress 1.1.x: ​http://trac.buddypress.org/browser/branches/1.1/bp-core/bp-core-classes.php#L71
I don't think core uses BP_Core_User->total_friends or total_groups any more, either. Maybe we can get rid of them

[slaFFik]

I think we should remain total groups - in case some plugins will use it.
I have deleted total blogs var. Patch attached.

[boonebgorges]

I'd rather not remove it, on the off chance that a plugin is using it. I'll just mark the property as deprecated.

[slaFFik]

But it's not aggregating anything in that class. So it's just an empty var - always. Don't know how it might be used by not giving it some value.
On the other hand total_groups has a value - so it should stay intact.
But as you wish, of course.

[boonebgorges]

(In [4896]) Marks BP_Core_User::total_blogs as deprecated. See #3147

[boonebgorges]

There may be a plugin that is extending BP_Core_User, and populating $total_blogs on their own. If I remove the declaration from the class, they'll get errors.

As for the question of $total_groups and $total_friends, I think that we will leave them in case of a plugin using them. Since they are only populated if you pass $populate_extras = true to the constructor (it's false by default), the presence of these properties doesn't have any performance effects for the average user.

[slaFFik]

Ok, thanks for explanation. Really appreciate your time for that.

[johnjamesjacoby]

Moving closed ticket out of Future Release.