Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3113 closed enhancement (fixed)

Add $settings_link variable to the various email notification filters.

Reported by: nerrad's profile nerrad Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Messages Keywords: notifications, filters, settings link
Cc:

Description

It would be VERY helpful if the $settings_link variable was included with the following filters:
‘messages_notification_new_message_message’
‘bp_activity_at_message_notification_message’
‘friends_notification_new_request_message’
‘friends_notification_accepted_request_message’

The $settings_link is dynamically calculated within the originating functions and is not easily duplicated (and in some cannot be duplicated) in any custom functions filtering the message content.

For context: The $settings_link is used for directing email recipients to their notifications settings page.

Change History (4)

#1 @nerrad
13 years ago

Probably should show an example for reference:

Currently in bp-messages-notifications.php we have:

$email_content = apply_filters( 'messages_notification_new_message_message', $email_content, $sender_name, $subject, $content, $message_link );

If we could change this to:

$email_content = apply_filters( 'messages_notification_new_message_message', $email_content, $sender_name, $subject, $content, $message_link, $settings_link );

Repeat for the other filters listed above. That would get the desired results and enable developers to better filter the text for directing email notification recipients to their settings page.

#2 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4144]) Passes settings_link variable to notification message filters. Fixes #3113. Props nerrad

#3 @boonebgorges
13 years ago

  • Milestone changed from Awaiting Review to 1.3

Ask and ye shall receive.

#4 @nerrad
13 years ago

Awesome, thanks :)

Note: See TracTickets for help on using tickets.