Inconsistent display of User name

[StevieG]

When looking at a members profile, you see the Display name followed by the @user_nicename. The help says this can be used to send messages to the member. However, if this user_nicename is changed to be different from the user login, messaging no longer works. you can see here ​http://bni-weymouth.org/members/LindaPH/activity/ that I have a member with a LOGIN username of Lindy, she has a DISPLAY name of Linda and I have changed the user_nicename to be LindaPH. Although the help sys that @LindaPH can be used in messaging it can't. To send a message you would still need to use @Lindy as can be verified by the Mentions count (also seen on this page). There needs to be a consistency between the fields used. I did this in order to hide the login usernames for administrators; this workes in that the url uses the user_nicename but the 'mentions' gives the game away!

[DJPaul]

This is a bigger problem than just the "at notifications". Some notes:

• URL is matched on user_nicename
• Private messaging recipients is checked against user_login
• Member profile's activity mentions page somewhere looks at user_login
• @autolinking is done on user_login
• A bunch of helper functions such as bp_core_get_userid() look at user_login

Do we switch everything over to user_nicename, or change the /members/<>/ URL to use the user_login? Do we want to touch this in 1.3 or leave for a release after that?

[DJPaul]

JJJ's said, for now, any place where the login/nicename is explicitly used, should be run through bp_core_get_username(). For example, /bp-default/_inc/ajax.php uses it for bp_dtheme_ajax_messages_autocomplete_results()

[DJPaul]

Oops, I forgot to tag my last commit, r4277, with this ticket, sorry:

Fix at-notifications to work when BP_ENABLE_USERNAME_COMPATIBILITY_MODE is not set and user_nicename != user_login

[djpaul]

(In [4294]) Fix private messaging recipients to work when BP_ENABLE_USERNAME_COMPATIBILITY_MODE is not set and user_nicename != user_login. See #3104

[DJPaul]

I believe this issue (@name being different from user_nicename or user_login) is now resolved. If anyone finds any other inconsistencies, please re-open the ticket.