Context Navigation

Changes between Initial Version and Version 1 of Ticket #3074, comment 11

initial	v1
1		Re 3074.04.patch. Your IS NOT NULL query assumes that blank rows in the profile data table for optional fields left blank. This may be the case during a normal profile edit (I would have to check) but it will not be the case if the admin creates a new profile field after the site is up and running. I'll grant that this is an edge case, and that your method is a bit easier to follow, but the method in 3074.03.patch does not have this shortcoming.
	1	Re 3074.04.patch. Your IS NOT NULL query assumes that blank rows exist in the profile data table for optional fields left blank. This may be the case during a normal profile edit (I would have to check) but it will not be the case if the admin creates a new profile field after the site is up and running. I'll grant that this is an edge case, and that your method is a bit easier to follow, but the method in 3074.03.patch does not have this shortcoming.
2	2
3	3	Also, as DJPaul pointed out in a private channel, the static $alt_row; is unnecessary since the query won't be returning empty rows. We can use a modulo instead.