Skip to:

Opened 13 years ago

Closed 13 years ago

Last modified 7 years ago

#3070 closed defect (bug) (fixed)

bp_before_directory_groups_list action duplicate

Reported by: travel-junkie's profile travel-junkie Owned by:
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Templates Keywords: needs-patch
Cc: stas@…


do_action( 'bp_before_directory_groups_list' ); is present right now (1.3-bleeding) in both groups/groups-loop.php and groups/index.php, which leads to duplicate content on the groups directorys page for any functions attached to this action.

Change History (8)

#1 @travel-junkie
13 years ago

The same actually happens on all directory pages.

#2 @DJPaul
13 years ago

  • Keywords needs-patch added; action removed
  • Milestone changed from Awaiting Review to 1.3

Patches welcome!

#3 @sushkov
13 years ago

I can't reproduce this.
Could you guide me, what steps you did to get duplicated results with this hook?


#4 @sushkov
13 years ago

  • Cc stas@… added

#5 @DJPaul
13 years ago

The do_action is in the two files mentioned in the ticket; it should probably only be in one. If someone hooks some HTML in, intended for once place, it'll appear twice. (probably take out of index.php, but see what happens to similar actions in the other templates)

#6 @sushkov
13 years ago

Yep, that's how I tested it.
I hooked a dummy function that is echoing something and I couldn't reproduce duplication in groups listings.

#7 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4270]) Remove duplicated template actions from directory pages. Fixes #3070

#8 @DJPaul
7 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.