Add Proper access to members options menu items

[sbrajesh]

Hi,
As of now, we check the access of an option menu in theme and show it. For making it more uniform we can use the "user_has_access" arg while adding item, so a theme can easily use bp_get_options_nav in more effective manner.
While the message and the settings component follow it properly, other components as groups/friends/profile do not follow it.

Here is a patch for that. It will allow a theme author to use bp_get_options_nav() without checking for proper rights and will give flexibility in theme design.

[sbrajesh]

just cleaning the tab alignment in earlier patch

[DJPaul]

(In r 4314) Specify user_has_access param on all items added to subnav. Fixes #3046, props sbrajesh

[wpmuguru]

In [4314] you added a second

'user_has_access' =>  bp_is_my_profile(),

​http://trac.buddypress.org/browser/trunk/bp-groups/bp-groups-loader.php?rev=4314#L231
​http://trac.buddypress.org/browser/trunk/bp-groups/bp-groups-loader.php?rev=4314#L233

[djpaul]

(In [4318]) Remove duplicated user_has_access param which was added in error in r4314. Fixes #3046, props wpmuguru

[johnjamesjacoby]

Also, not all of these should be bp_is_my_profile(). Double check the logic here, but things like forum topics/replies are public everywhere else, so no reason not to allow other users to see the forum activity of other users.

[DJPaul]

I'm going to revert all of this and take a detailed look at each change this weekend

[djpaul]

(In [4321]) Revert all of r4314. See #3046

[DJPaul]

In dev chat, we decided to move this to a future release because of unintended consequences with globally applying this patch, like above. sbrajesh, if you or anyone else finds that this not being fixed prevents you doing something, please clarify details.

[boonebgorges]

As a rule, it would be nice to use the 'user_has_access' parameter rather than putting checks into templates. But I'm not sure how much of the suggested changes are still applicable.

On that note, I'm going to close the ticket. But sbrajesh, if you still find inconsistencies, feel free to reopen with details.