Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

#3041 closed defect (bug) (fixed)

Component Settings Cannot Save

Reported by: johnpbloch Owned by:
Priority: normal Milestone: 1.5
Component: Core Version: 1.5
Severity: Keywords: has-patch
Cc:

Description

Because of the way the code handles disabling components, it will not save disabled components. It tries to check if the submitted value for the component's checkbox does not equal 1; unfortunately, browsers do not send a value at all for checkboxes that aren't checked. So if I'm trying to disable the forum component, for example, the $_POSTbp_components array simply does not contain an item with the key 'bp-forums.php'. Will attach a patch momentarily.

Attachments (1)

3041.patch (6.4 KB ) - added by johnpbloch 15 years ago.
This patch creates a function to return all available components (disabled and enabled); when disabling components, we need to check against a centralized list of components to know what should be disabled.

Download all attachments as: .zip

Change History (4)

@johnpbloch
15 years ago

This patch creates a function to return all available components (disabled and enabled); when disabling components, we need to check against a centralized list of components to know what should be disabled.

#1 @johnpbloch
15 years ago

  • Keywords has-patch added

#2 @DJPaul
15 years ago

  • Milestone Awaiting Review1.3

Need to check if this is still relevant

#3 @boonebgorges
15 years ago

  • Resolutionfixed
  • Status newclosed

I believe this is working now, with recent changes to the way that the component info is stored. Please reopen if you continue to have problems.

Note: See TracTickets for help on using tickets.