Skip to:
Content

Opened 8 years ago

Closed 8 years ago

#3022 closed enhancement (fixed)

%member% has changed their avatar in Activity Stream

Reported by: bigjimmysisco Owned by:
Milestone: 1.5 Priority: minor
Severity: Version: 1.5
Component: Extended Profile Keywords: has-patch
Cc:

Description

Like Facebook functionality, when a user changes their avatar, a new activity stream post is entered, saying %member% has changed their avatar

Attachments (4)

3022.01.patch (1.2 KB) - added by r-a-y 8 years ago.
3022.02.patch (1.2 KB) - added by r-a-y 8 years ago.
Swap out function_exists() call for bp_is_active()
3022.03.patch (1.2 KB) - added by cnorris23 8 years ago.
3022.04.patch (1.2 KB) - added by cnorris23 8 years ago.
First patch was overzealous with the prefixing

Download all attachments as: .zip

Change History (18)

#1 @DJPaul
8 years ago

  • Keywords change avatar in activity stream removed
  • Milestone changed from Awaiting Review to 1.3

This would be nice to get in 1.3 if there is time

@r-a-y
8 years ago

#2 @r-a-y
8 years ago

  • Component changed from Core to XProfile
  • Keywords has-patch added

@r-a-y
8 years ago

Swap out function_exists() call for bp_is_active()

@cnorris23
8 years ago

#3 @cnorris23
8 years ago

New patch adds 'bp_' prefix to function/filter names.

@cnorris23
8 years ago

First patch was overzealous with the prefixing

#4 @DJPaul
8 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

#5 @DJPaul
8 years ago

  • Owner DJPaul deleted

#6 @boonebgorges
8 years ago

This looks quite lovely. I'll commit and we can iterate if necessary.

#7 @boonebgorges
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4273]) Creates an activity item when users change their avatars. Fixes #3022. Props cnorris23

#8 @DJPaul
8 years ago

What about making it read "...changed their profile picture"?

#9 @boonebgorges
8 years ago

  • Priority changed from normal to minor

Yeah, I think I like that better. Any objections?

#10 @boonebgorges
8 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#11 @r-a-y
8 years ago

I've got no problems with it.

Just a question about the patch that got committed, are we prefixing "bp_" to function and filter names now?

#12 @DJPaul
8 years ago

Going forwards, function prefixes will be bp_. Eventually, the xprofile, groups and friends functions will be switched.

#13 @djpaul
8 years ago

(In [4288]) Update text for the new "changed their avatar" activity stream action. See #3022

#14 @DJPaul
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Closing the ticket again to keep the milestone tidy. Feel free to re-open if anyone has further comments :)

Note: See TracTickets for help on using tickets.