#3009 closed enhancement (fixed)
bp-activity-comments Vs. wp-comments
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 1.6 | Priority: | normal |
| Severity: | normal | Version: | 1.5 |
| Component: | Templates | Keywords: | |
| Cc: |
Description
In reference to this thread:
I'm proposing a quick fix short term solution for changing activity comments to use a OL list in place of the hardcoded UL.
Comments are correctly described using an OL list and this is as used by TwentyTen.
bp-activity-templatetags.php ~line 695 has hardcoded markup where it doesn't really belong (at least to that degree) as noted by the script comment to remove.
Attached is a quick patch to that file changing UL to OL however I have just realised that we have jQuery at work overriding this markup so that needs to be found and also changed.
There is a possible backwards compatibility issue for child themes if they have styles on ul.commentlist but that is one example of why best not to style in that manner with dynamic themeable apps. regardless of breaking the odd theme I would argue this change still needs to be effected otherwise we run in fear of ever making necessary changes, it is not too much to ask that child themes update and that authors check the release notes before upgrading!
Attachments (1)
Change History (8)
#3
@
12 years ago
- Keywords changed from has-patch, dev-feedback to has-patch dev-feedback
- Resolution set to invalid
- Severity set to normal
- Status changed from new to closed
Not sure this needs to still be part of it with theme independence - if it does please reopen though and I agree it should be consistent.
This breaks CSS selectors in BuddyPress. If BP-Default styles using it, I think we should expect child themes to as well. While I agree that OL would be semantically more appropriate, I'm not sure it's worth breaking this compatibility in the theme for this reason alone.