'bp-wizard-step' cookie in setup/upgrader not cleared

[DJPaul]

The 'bp-wizard-step' cookie, as used in the setup/upgrader process, is not cleared until the process completes successfully. That is correct behaviour, but as a result of developing on core, I've noticed that if I re-install WordPress part-way through the BuddyPress setup process (i.e. when the cookie is set), when the BuddyPress setup process is run a second time, the cookie is not cleared.

This results in the setup process jumping to the wrong step of the installation, and this can cause BuddyPress to think that it is fully set up before it actually is, leading to fatal PHP errors.

[DJPaul]

2999.patch is how to fix it, but not WHERE to fix it. It needs to almost be after plugin activation -- the patch has the unintended consequence of letting people restart the setup process if they go to another WP admin page, and then come back to the BP setup. Since each "page" of the setup process is actioned on form submit, we would end up with double action being taken.

[DJPaul]

This has been fixed in trunk sometime ago, presumably as a consequence of other changes.