XProfile Tabs lack filter

[sushkov]

In [branches/1.2/bp-xprofile/bp-xprofile-templatetags.php#L590]

do_action( 'xprofile_profile_group_tabs' );
should be a filter in order to be able to manipulate data.

I can't change nor hide xprofile group tabs currently.

Thanks.

[sushkov]

​http://trac.buddypress.org/browser/branches/1.2/bp-xprofile/bp-xprofile-templatetags.php#L590

Direct link to the file.

[djpaul]

(In [3663]) Add filter to bp_profile_group_tabs(). Fixes #2996

[hnla]

Sadly this fix introduces errors, for every valid group field there is generated an extra empty LI element, tried to pin it down but out of time, looks like the $i incremental is adding + 1 to each 'foreach' looped item.

I reverted the change manually and the issue is resolved.

[DJPaul]

When you say an empty element, do you mean literally "<li></li>"?

[hnla]

Yep literally:

one for each genuine li element as I said above likely the way you re-factored things and the incrementing, check it on one of your test installs, don't think I'm going mad :)

[djpaul]

(In [4451]) Fix typo in r3663. Fixes #2996 again

[hnla]

Can't believe I didn't spot that simple missing '/' looking for more complex reasons and overlooked the simplest one :(

[DJPaul]

It took me much too long to spot it, too!