Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#2987 closed enhancement (fixed)

cleanup in notification settings

Reported by: wpmuguru's profile wpmuguru Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords:
Cc:

Description

The notification settings repeat calls to get_user_meta for the same data. Also, there is a WP core function for checking radio buttons and checkboxes.

BP should use the core function & should not repeat data retrieval (even if from cache) within the same function. The core function also makes the code cleaner and easier to follow.

Attachments (1)

2987.diff​ (14.3 KB) - added by wpmuguru 14 years ago.

Download all attachments as: .zip

Change History (4)

@wpmuguru
14 years ago

#1 @wpmuguru
14 years ago

That patch is for trunk.

#2 @DJPaul
14 years ago

  • Milestone changed from Awaiting Review to 1.3
  • Owner set to DJPaul
  • Status changed from new to accepted

Awesome, didn't know about that function. We'll have to update xprofile admin screen probably, too, at some point. Thanks for the patch :)

#3 @djpaul
14 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [3633]) Cleanup code in notification settings, and don't reinvent the wheel. Fixes #2987, props wpmuguru

Note: See TracTickets for help on using tickets.