Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

Last modified 8 years ago

#2978 closed enhancement (fixed)

comments.php is not using comment_form()

Reported by: djpaul's profile DJPaul Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Templates Keywords: commit gci
Cc:

Description

BP-Default's comments.php is not using comment_form() for the comment form. This should be changed so that BP-Default doesn't fail on this for the ​theme-check. This ought to be an invisible change on the front-end so styles will need updating.

Attachments (1)

comments.patch​ (6.1 KB) - added by denis.ogun 14 years ago.

Download all attachments as: .zip

Change History (5)

@denis.ogun
14 years ago

#1 @denis.ogun
14 years ago

I have implemented this locally and it looks the same as before comment_form() was used. This was done for a Google Code In task.

#2 @DJPaul
14 years ago

  • Keywords commit added; needs-patch removed
  • Owner set to DJPaul
  • Status changed from new to assigned

Patch is really good -- thanks very much for the contribution, I've marked the GCI task as complete :)

BuddyPress-wise, before committing, I'm going to have a think about creating a convenience wrapper function so we don't have to have so much $defaults properties in the actual template. If anyone's got a good idea on how best to do this, let us know.

#3 @djpaul
14 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3624]) Use comment_form() to comply with WP theme standards and improves code style in comments.php. Fixes #2978. Props denis.ogun (via Google Code In)

#4 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.