Skip to:

Opened 13 years ago

Closed 13 years ago

#2970 closed defect (bug) (fixed)

duplicate sql in BP_Activity_Activity::get/get_specific

Reported by: djpaul's profile DJPaul Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Activity Keywords:


BP_Activity_Activity::get and BP_Activity_Activity::get_specific methods are similar and share a lot of common SQL. get_specific() is used on an activity's permalink page. What it doesn't do, compared to get(), is fetch the user's user_fullname. This is an inconsistency and can possibly lead to a second SQL query.

In trunk, get() allows for activity IDs to be included or excluded from the results. We can use these new parameters to remove all of the duplicate functionality from get_specific().

Change History (1)

#1 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3580]) Consolidate BP_Activity_Activity::get_specific/::get methods. Fixes #2970, reverts a part of r 3566 and fixes a PHP notice.

Note: See TracTickets for help on using tickets.