[Patch] Public/Moderated groups, better RSS descriptions, fix an error

[jefferai]

Attached is a patch that does the following:

1) Fixes a bug in bp_core_fetch_avatar_filter where $alt may not be specified in the call but was not defaulting to anything.

2) Adds "modmems" or "Moderated Members" groups. Groups of this type require moderator permission to become members (and thus to create content) but all content is public.

3) Adds a function to provide a common name for some components; this allows RSS feeds for the various Activities types to show different names for the feeds (instead of just "Activity", making it clear to the user that in fact the RSS feeds are different for each activity.

[DJPaul]

Can you split these into individual patches and trac tickets please?

[jefferai]

Not easily, or I'd have done that already. :-) Trying to manually fudge diffs usually makes them not apply correctly, and the changes for the different problems are in the same files.

[DJPaul]

jefferai, I think Boone and I discussed this with you on IRC a month or two ago. Were you going to re-submit smaller patches?

[DJPaul]

If these issues are still current, we still need separate patches for them. The above is too much to review.

[DJPaul]

Closing ticket as these issues should be addressed in individual patches and trac tickets. For the record: point 2 sounds like it should be implemented as plugin (we're happy to add more hooks or actions if not already possible). Points 1 and 3 looks like they do not need fixing, but the tickets need more details on how to recreate the issue.

[jefferai]

#1 in ​http://buddypress.trac.wordpress.org/ticket/3225

[jefferai]

3) in ​http://buddypress.trac.wordpress.org/ticket/3226

[johnjamesjacoby]

Moving closed ticket out of Awaiting Review.