Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#2955 closed enhancement (no action required)

[Patch] Public/Moderated groups, better RSS descriptions, fix an error

Reported by: jefferai's profile jefferai Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

Attached is a patch that does the following:

1) Fixes a bug in bp_core_fetch_avatar_filter where $alt may not be specified in the call but was not defaulting to anything.

2) Adds "modmems" or "Moderated Members" groups. Groups of this type require moderator permission to become members (and thus to create content) but all content is public.

3) Adds a function to provide a common name for some components; this allows RSS feeds for the various Activities types to show different names for the feeds (instead of just "Activity", making it clear to the user that in fact the RSS feeds are different for each activity.

Attachments (1)

buddypress-jeff.patch (23.0 KB) - added by jefferai 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @DJPaul
11 years ago

Can you split these into individual patches and trac tickets please?

#2 @jefferai
11 years ago

Not easily, or I'd have done that already. :-) Trying to manually fudge diffs usually makes them not apply correctly, and the changes for the different problems are in the same files.

#3 @DJPaul
11 years ago

jefferai, I think Boone and I discussed this with you on IRC a month or two ago. Were you going to re-submit smaller patches?

#4 @DJPaul
11 years ago

  • Keywords needs-patch added

If these issues are still current, we still need separate patches for them. The above is too much to review.

#5 @DJPaul
11 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Closing ticket as these issues should be addressed in individual patches and trac tickets. For the record: point 2 sounds like it should be implemented as plugin (we're happy to add more hooks or actions if not already possible). Points 1 and 3 looks like they do not need fixing, but the tickets need more details on how to recreate the issue.

#8 @johnjamesjacoby
11 years ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 1.5
  • Severity set to normal

Moving closed ticket out of Awaiting Review.

Note: See TracTickets for help on using tickets.