Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#2770 closed defect (bug) (fixed)

Delete others activity in my profile

Reported by: ezd's profile Ezd Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords:
Cc:

Description

Hi,

Don't know if this has been made on purpose or not but if I goto my "Following" tab here:
http://testbp.org/members/ezcali/activity/following/

I can actually delete activity by other users just like under the "Personal" tab. But NOT in "Groups", "Favorites" and the latest favorite by Andrew Wayne in the "@ezcali Mentions".

Shouldn't the delete option go through all tabs or maybe it shouldn't be allowed to delete stuff inside the "Following" tab in the first place?

Attachments (1)

2770-1.patch (1.6 KB) - added by boonebgorges 13 years ago.

Download all attachments as: .zip

Change History (4)

#1 @Ezd
13 years ago

The thing that bugs is that I thought it was only my own activity that I could delete from the site. Now I'm actually able to delete others activity too, in my profile.

#2 @boonebgorges
13 years ago

This is specifically a problem with the Followers plugin, but it points to an improper use of is_item_admin.

Have a look at 2770-1.patch. It checks against $bp->is_item_admin && $bp->is_single_item so that is_item_admin is only relevant in the places where it was meant to work, ie on single items like groups.

#3 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3563]) Refines the check to see whether a user has permissions to delete an activity item. Fixes #2770

Note: See TracTickets for help on using tickets.