#2753 closed enhancement (fixed)
Suggested CSS styles to add to default theme: del, big, ins, sup, sub, sticky and gallery-caption
Reported by: | karmatosed | Owned by: | DJPaul |
---|---|---|---|
Milestone: | 1.5 | Priority: | normal |
Severity: | Version: | ||
Component: | Templates | Keywords: | |
Cc: |
Description
Several classes that the default theme is missing which it needs to pass the theme review test and also will benefit as basic styling.
These can be seen in the screen shot attached and are suggested basic formats to start from whilst trying to keep the styling already set up in the theme.
CSS styles proposed:
del { del { text-decoration: line-through; } big { font-size: 131.25%; } ins { background: #ffc; text-decoration: none; } sup, sub { height: 0; line-height: 1; vertical-align: baseline; _vertical-align: bottom; position: relative; } sup { bottom: 1ex; } sub { top: .5ex; } .sticky { background: #FFF9DB; border-top: 1px solid #FFE8C4; border-bottom: 1px solid #FFE8C4; padding: 5px; } div.post .gallery .gallery-caption { color: #888; font-size: 12px; }
Attachments (2)
Change History (15)
#4
@
14 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Sorry, wrong ticket.
#6
@
14 years ago
For the big style how about:
big { font-size: 18px; }
For sticky have 3 suggested formats and image attached (stickstyles.jpg) showing these.
- sticky same style as table sticky for forums
.sticky { background: #FFF9DB; border-top: 1px solid #FFE8C4; border-bottom: 1px solid #FFE8C4; color: #FFA200; padding: 5px; }
- grey sticky style
.sticky { background: #F0F0F0; padding: 5px; }
- no border just background colour sticky
.sticky { background: #FFF9DB; color: #FFA200; padding: 5px; }
#7
@
14 years ago
Ammendment: I think 3 should be without colour on text (updated sticky image to show this):
- no border just background colour sticky
.sticky { background: #FFF9DB; padding: 5px; }
#8
@
14 years ago
Tammie you've let those uppercase hex values creep in again tut tut ;) I do it all time myself as it's unimportant and select and paste from colour apps most of the time cos I've only memorized 6 hex numbers :(
More concerning though is this setting of pixel font sizes, don't know where they came from but it's not best practice, relative measures are usually used as they allow pages to scale smoothly and more importantly do not interfere or prevent the users browser font size choice.
#9
@
14 years ago
The font-sizes in BP-Default are already in pixels which is why I didn't want to commit a % value for <big>
#10
@
14 years ago
Yep realised that Paul and agree it's somewhat worse to start mixing measures and at this stage probably not a great idea to try and change them all as it's a tougher task than it seems, just a pity that route was taken.
#11
@
14 years ago
Whilst the point of px / em / % is such a debatable one I think having one rule is the key maybe here so tend to agree lets do px.
Eeep it's like I"m blind to it now also... sorry about caps.
- sticky same style as table sticky for forums
.sticky { background: #fff9db; border-top: 1px solid #ffe8c4; border-bottom: 1px solid #ffe8c4; color: #ffA200; padding: 5px; }
- grey sticky style
.sticky { background: #f0f0f0; padding: 5px; }
- no border just background colour sticky
.sticky { background: #fff9db; padding: 5px; }
An amendment as it should read:
not...