Skip to:
Content

Opened 3 years ago

Closed 3 years ago

#2748 closed enhancement (fixed)

Add .bypostauthor class CSS

Reported by: karmatosed Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Theme Keywords:
Cc:

Description

Here is my CSS suggestion for a .postauthor class. We will probably want this changed with new comment styling for 1.3 but should at least get something in there to link up with that class.

ol.commentlist .bypostauthor{
	background: #EEEEEE;
	padding: 10px 10px 0px 0px;
	border: 1px solid #EEEEEE;
	-moz-border-radius: 3px;
	-webkit-border-radius: 3px;
	border-radius: 3px;
}

Attached image of what it looks like.

Attachments (3)

postauthor.jpg (26.2 KB) - added by karmatosed 3 years ago.
Postauthor class mockup
2748-1.patch (614 bytes) - added by DJPaul 3 years ago.
realpic.png (37.7 KB) - added by DJPaul 3 years ago.
2748-1 screenshot

Download all attachments as: .zip

Change History (10)

karmatosed3 years ago

Postauthor class mockup

comment:1 karmatosed3 years ago

  • Summary changed from Add .postauthor class CSS to Add .bypostauthor class CSS

comment:2 karmatosed3 years ago

  • Version 1.3 deleted

DJPaul3 years ago

DJPaul3 years ago

2748-1 screenshot

comment:3 DJPaul3 years ago

I think the grey colour was a bit too heavy to use that much of it, and I didn't easily see the lighter-coloured borders line. I've put up a patch and picture based on your concept, but applied to the author's name area.

comment:4 karmatosed3 years ago

Cool that works and like it a lot.

My only concern is the notes from Theme Review are not clear and say include class but don't say if has to be a full class. That said I don't see the argument against a reference like this as it's still showing what is a post author.

I agree though in hindsight not sure a full on class works with the current comment styling at all. Unless you add padding and have same background to border (then loosing border) like I did example it looks odd. I guess only running through test will tell us if this is acceptable - I as said think worth questioning why if fails.

Another option thinking this morning would be changing border colour on the avatar.

comment:5 DJPaul3 years ago

Changing a comment avatar's border colour for the post author would create an inconsistency with the post's author avatar at the top of the page.

comment:6 DJPaul3 years ago

This will need patching once we get the updated comment styles (to match the activity stream styles).

comment:7 djpaul3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3687]) Adds .bypostauthor and 'big' CSS styles, and defines $content_width in functions.php, to meet WordPress Theme Review guidelines. Props to karmatosed. Fixes #2748 and #2753.

Note: See TracTickets for help on using tickets.