#2748 closed enhancement (fixed)
Add .bypostauthor class CSS
Reported by: | karmatosed | Owned by: | |
---|---|---|---|
Milestone: | 1.5 | Priority: | normal |
Severity: | Version: | ||
Component: | Templates | Keywords: | |
Cc: |
Description
Here is my CSS suggestion for a .postauthor class. We will probably want this changed with new comment styling for 1.3 but should at least get something in there to link up with that class.
ol.commentlist .bypostauthor{ background: #EEEEEE; padding: 10px 10px 0px 0px; border: 1px solid #EEEEEE; -moz-border-radius: 3px; -webkit-border-radius: 3px; border-radius: 3px; }
Attached image of what it looks like.
Attachments (3)
Change History (11)
#3
@
14 years ago
I think the grey colour was a bit too heavy to use that much of it, and I didn't easily see the lighter-coloured borders line. I've put up a patch and picture based on your concept, but applied to the author's name area.
#4
@
14 years ago
Cool that works and like it a lot.
My only concern is the notes from Theme Review are not clear and say include class but don't say if has to be a full class. That said I don't see the argument against a reference like this as it's still showing what is a post author.
I agree though in hindsight not sure a full on class works with the current comment styling at all. Unless you add padding and have same background to border (then loosing border) like I did example it looks odd. I guess only running through test will tell us if this is acceptable - I as said think worth questioning why if fails.
Another option thinking this morning would be changing border colour on the avatar.
#5
@
14 years ago
Changing a comment avatar's border colour for the post author would create an inconsistency with the post's author avatar at the top of the page.
#6
@
14 years ago
This will need patching once we get the updated comment styles (to match the activity stream styles).
Postauthor class mockup