Remove avatar upload before account activation

[DJPaul]

I suggest we remove the avatar upload from the user registration/activation process of BP-Default.

Currently people can upload an avatar prior to their account being activated, and complete their initial profile. The difference between the two is that xprofile data is always text, and so can live within a database in a compact format. An avatar exists as a JPG someplace on the server.

Aside from technical issues, I believe the UX of account registration is very non-standard for no beneficial reason. (the UX looks like: fill out registration -> upload avatar -> activate account -> login)

Patch attach removes the avatar upload step on user registration. I've also taken out the template_notices do_action() as currently we get duplicate "thanks for [registering|activating] your account" messages with the page template.

[hnla]

Absolutely agree with above. Always had an problem with this aspect and would always look to remove this stage before a user had activated their account.

Ideally on activation one would be logged in and dropped into account profile area where it was clear that avatar upload and profile details could be completed or else simply go ahead and explore.

[DJPaul]

I want to put this in but awaiting feedback. Has anyone got any?

[boonebgorges]

I agree that it's awkward and non-standard to offer avatar upload before activation. However, taking the avatar upload step out of the signup process altogether will probably mean that far, far fewer users will upload avatars.

Any votes for adding an avatar-upload step after activation? It could go right in the activation template.

Something like hnla suggests (where a user can be redirected to a regular profile edit page or avatar upload page on the first login) would be even better in a sense, but harder to do. Is there any existing data we could use to detect first logins? When is last_activity first updated?

[DJPaul]

last_activity is first set in bp_core_activate_signup(), which gets invoked before the activation page template is loaded again. User is still logged out at this point.

[djpaul]

(In [3691]) Remove avatar upload before account activation. Fixes #2741

[sooskriszta]

@boonebgorges Totally with you. #4132