Skip to:
Content

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2739 closed enhancement (wontfix)

Add template_notices to theme files

Reported by: travel-junkie Owned by: travel-junkie
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Theme Keywords:
Cc:

Description

Sometimes it might be necessary to display error/success messages on posts or archive pages, so we could add

<?php do_action( 'template_notices' ) ?>

to single.php, archive.php, page.php and index.php

Attachments (4)

archive.php (2.6 KB) - added by travel-junkie 3 years ago.
index.php (2.4 KB) - added by travel-junkie 3 years ago.
single.php (2.3 KB) - added by travel-junkie 3 years ago.
page.php (1.0 KB) - added by travel-junkie 3 years ago.

Download all attachments as: .zip

Change History (12)

travel-junkie3 years ago

comment:1 travel-junkie3 years ago

  • Owner set to travel-junkie
  • Status changed from new to accepted

travel-junkie3 years ago

travel-junkie3 years ago

travel-junkie3 years ago

comment:2 hnla3 years ago

Apologies duplicated your effort on:

http://trac.buddypress.org/ticket/2740

Patch file containing above files plus onecolumn-page.php

comment:3 DJPaul3 years ago

I had a look at this, and I'm not sure adding the notification area to the WordPress templates works very well in practice. I think finding the best place in those templates is very hard, and is probably use-case specific.

travel-junkie: I think you said on a forum post about this, that you had written a component that needed this area on the blog templates? Can you explain what this component did and try to make the case for why this needs to be in the core template?

comment:4 DJPaul3 years ago

  • Milestone changed from 1.3 to Awaiting Review

comment:5 DJPaul3 years ago

  • Resolution set to wontfix
  • Status changed from accepted to closed

Closing this as wontfix unless someone has a good use case for this.

comment:6 r-a-y3 years ago

Actually the template_notices action is needed on the activity permalink page when posting without javascript.

comment:7 DJPaul3 years ago

That'd be a new ticket; please would you make one if its needed? As I understand, this ticket is about adding template_notices to standard WordPress template files such as index.php and single.php.

comment:8 johnjamesjacoby3 years ago

  • Milestone changed from Awaiting Review to 1.5
  • Severity set to normal
  • Version 1.5 deleted

Moving closed ticket out of Awaiting Review.

Note: See TracTickets for help on using tickets.