Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#2712 closed enhancement (fixed)

[patch] Use WordPress' gravatar settings

Reported by: DJPaul Owned by: DJPaul
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords: has-patch, dev-feedback
Cc:

Description

On BuddyPress' admin settings, we have an option to set the user gravatar default. We also use it for group and blog gravatars, even though we only describe the option as for users. WordPress has a similar option to control gravatars used on comments.

I think BuddyPress overlaps with the WordPress core in this case, and provides no additional benefit. I don't think adding more options to set default group and blog gravatars would be of much value. Most sites seem to use the same gravatar default throughout.

Patch attached to make this change, feedback appreciated.

Attachments (1)

oncemoreonceagain.patch (3.8 KB) - added by DJPaul 9 years ago.

Download all attachments as: .zip

Change History (8)

#1 @boonebgorges
9 years ago

I like the idea of removing this redundant option, and thus I like this patch.

On the larger issue of default avatars, I think that it's a *good* idea to give more flexibility in terms of default avatars for different components (right now it's very difficult to do anything custom with avatars). But I don't necessarily think it should be an admin option - more like a filterable value. Probably worthy of a different enhancement ticket.

#2 @DJPaul
9 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

Before we commit this, we need to put code in the upgrader to migrate from the settings so that people's preference isn't reset.

#3 @boonebgorges
9 years ago

See #2697. Maybe my patch on #2697 should be updated to look at $bp->grav_default (why not get rid of the 'user' bit and just have the whole thing filterable in bp_core_fetch_avatar()?) - except it'd have to be an absolute filepath, so maybe we'd need a different $bp->avatar_default.

#4 @djpaul
9 years ago

(In [3443]) Use WordPress' gravatar settings. See #2712.

#5 @DJPaul
9 years ago

Ticket left open as a reminder to signpost this change when we update the admin pages.

#6 @paulhastings0
9 years ago

  • Summary changed from Use WordPress' gravatar settings to [patch] Use WordPress' gravatar settings

#7 @DJPaul
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Closing ticket as I'm sure I'll remember :)

Note: See TracTickets for help on using tickets.