Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#2711 closed enhancement (fixed)

[patch] BP_Button improvements

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.5 Priority: normal
Severity: Version: 1.2.6
Component: Core Keywords: has-patch
Cc:

Description

Per todays dev meeting, a branch patch for improving HTML output of BP_Button.

Attachments (2)

bp-button.patch​ (13.3 KB) - added by johnjamesjacoby 14 years ago.
"Life goes on, and so do we..."
bp-button-2.patch​ (13.0 KB) - added by DJPaul 14 years ago.

Download all attachments as: .zip

Change History (9)

@johnjamesjacoby
14 years ago

"Life goes on, and so do we..."

#1 @johnjamesjacoby
14 years ago

Patch duplicates classes from wrapper div to anchor. In 1.3 we can look at improving this further, but at present there isn't an easy way to give themes control over buttons AND give plugins control over their output while also allowing bp-default ajax to continue to function without more changes there too.

#2 @DJPaul
14 years ago

Looks alright to me. I'd personally like to see the wrapper default to false, and to set it in the button generating functions such as bp_group_new_topic_button().

I'd also strongly suggest we just put this into 1.3 and not 1.2.7.

#3 @DJPaul
14 years ago

But I'm quite happy for this to go in as-is, don't get me wrong :)

#4 @paulhastings0
14 years ago

  • Summary changed from BP_Button improvements to [patch] BP_Button improvements

#5 @DJPaul
14 years ago

  • Milestone changed from 1.2.7 to 1.3

@DJPaul
14 years ago

#6 @DJPaul
14 years ago

Patch refreshed for latest trunk, and phpdoc tweaked.

#7 @djpaul
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3685]) Adds additional arguments to the BP_Button class to allow for greater customisation in themes. Fixes #2711, props johnjamesjacoby.

Note: See TracTickets for help on using tickets.