Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#2710 closed defect (bug) (fixed)

Search is broken due to bp_pages support

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 1.5 Priority: major
Severity: Version: 1.5
Component: Core Keywords:
Cc:

Description

BP search works by sending a request to example.com/search. The function bp_core_action_search_site() then catches page loads to check whether the current_component is BP_SEARCH_SLUG.

In 1.3 trunk, root components are not registered with bp_core_add_root_component(), because they are dependent on WP pages. BP auto-creates pages for other root components, but not for Search.

Attachments (1)

2710-1.patch (1.4 KB) - added by boonebgorges 9 years ago.

Download all attachments as: .zip

Change History (4)

#1 @boonebgorges
9 years ago

Here's one strategy: 2710-1.patch

@boonebgorges
9 years ago

#2 @boonebgorges
9 years ago

After reviewing this patch, Paul correctly pointed out that it's probably safer to check against $bp_uri[0] than the entire array, since a group or member or page might be called 'search'. I'm committing a patch with that modification.

This points out the potential need for a top-level search directory page. I've opened a separate enhancement ticket for discussion of that issue: #2767

#3 @boonebgorges
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3490]) Modifies bp_core_set_uri_globals() to properly catch search requests. Fixes #2710

Note: See TracTickets for help on using tickets.