bp_format_time returns incorrect value when gmt_offset is empty

[stevejohnson]

When the root blog's timezone is set to a Region/City string, WP sets the option timezone_string, and gmt_offset value is empty. Only when the timezone is set to a GMT time does gmt_offset contain a value. This results in incorrect time strings for anything that uses bp_format_time.

Function bp_format_time should be modified to take this into account.

[DJPaul]

Can you confirm if you tested this on PHP4 or PHP5?

[stevejohnson]

PHP 5.2.4

This ticket may need to be modified/deleted. The issue is more widespread than in just bp_format_time. I need to do some more investigation. To date, I've had to write 3 filters affecting 3 different date/time reporting functions.

I'll see if I can dig deeper.

Replying to DJPaul:

Can you confirm if you tested this on PHP4 or PHP5?

[johnjamesjacoby]

In 9294:

Unit tests for bp_format_time() to test gmt_offset and timezone_string. See #2693.

[johnjamesjacoby]

This might be invalid, thanks to wp_timezone_override_offset() introduced in WordPress 2.8.0. Added the above unit tests to help confirm some suspicions, though I think there are more conditions worth testing here.

[johnjamesjacoby]

In 9295:

Explicitly set date_format and time_format options in bp_format_time() tests. See #2693.

[johnjamesjacoby]

In 9616:

Core: Update tests for bp_format_time:

• Include 2 new tests without localization, useful for maintaining sanity.
• Update 2 existing tests to include WordPress core default options.
• Update timezone_string test time to look for "2:00 pm" (as it is theoretically DST aware) though there is likely more to test here.

See #2693.

[johnjamesjacoby]

In 9617:

Core: Update bp_format_time:

• Use bp_get_option() over get_blog_option() and (incorrect) get_option() calls.
• Rename variables for clarity, as generic date/time/offset variables were easy to accidentally stomp.
• Port logic from wp_timezone_override_offset() and calculate timezone offset if timezone_string is set in the root blog's options.
• Pass $localize_time parameter into date_i18n() function call, to ensure the most accurate results possible are returned back from WordPress.

See #2693.

[johnjamesjacoby]

In 9618:

Core: Clean up bp_format_time:

• More detailed phpdoc block.
• Add @since tag.
• White space is delicious.
• Rename parameters to avoid double negative checks.
• Rename another variable.

See #2693.

[boonebgorges]

Is this done?

[johnjamesjacoby]

In trunk, yes. I am about 90% certain. :)

[johnjamesjacoby]

Confirmed complete in trunk for 2.3.0.

Closing as fixed.