Canonicalization of Buddypress URLs

[lucianop]

When I visit a BuddyPress-generated URL (such as ​http://example.com/activity), I am not redirected to a properly canonicalized url.

For example, I can go to:

http://example.com/activity

http://example.com/activity/

In Wordpress, the default behavior is whether I type the url without trailing slash, I get redirected to the canonicalized version (with trailing slash).

[boonebgorges]

This would be worth doing but it probably won't happen for 1.3 unless someone provides a patch.

[r-a-y]

Interestingly, changing Wordpress' canonical action hook from "template_redirect" to "get_header" fixes this for BuddyPress.

No time for a patch, but try changing this line in /wp-includes/canonical.php:

add_action('template_redirect', 'redirect_canonical');

to:

add_action( 'get_header', 'redirect_canonical', 0 );

Not sure if there are any side-effects with doing this.

[r-a-y]

The patch checks if the current page is a blog page ( WP page, post, archive, etc. ) with bp_is_blog_page(), then adds a hook to "get_header" with a priority of zero, so it runs first, directly after "template_redirect"; "get_header" is the action following "template_redirect".

---

Tested lightly; it redirects BP pages to their trailingslashit equivalent.

Anchors in URLs are preserved; haven't checked queries, but should work as well.

[DJPaul]

Related to #1741

[boonebgorges]

2681.002.patch is the function that I've come up with to handle this. I've hooked it to a new do_action() in bp_core_load_template(), so that the redirect only takes place for pages that are viewable in a browser (mimicking the fact that WP does the redirect at template_redirect).

This patch will have to be accompanied by a gigantic audit of our own redirect and URL-building functions. We want to avoid redirects where possible, so we should be building our URLs appropriately - with the trailing slash. I'll work on it. In the meantime, feedback welcome on 2681.002.

[boonebgorges]

(r-a-y, I couldn't get your patch to work right. WP's redirect_canonical didn't seem to do anything for me.)

[boonebgorges]

Whoops, this was fixed in r5412.