bp_core_set_uri_globals() should urldecode() path parts

[mdawaffe]

If a user has a user_login with a space in it, for example, and BP_ENABLE_USERNAME_COMPATIBILITY_MODE is enabled, bp_core_set_uri_globals() will report the username as "Blah%20Foo" instead of "Blah Foo".

Attached fixes that one place, but there may be other similar places that need urldecoding.

[DJPaul]

Attached patch is against trunk. mdawaffe, does this affect the 1.2 branch? (I assume it does)

[mdawaffe]

Replying to DJPaul:

Attached patch is against trunk. mdawaffe, does this affect the 1.2 branch? (I assume it does)

I don't know. I only have access to a trunk install to test.

Here's an example in the wild:
​http://profiles.wordpress.org/users/mdawaffe/ works as expected
​http://profiles.wordpress.org/users/Hiroaki%20Miyashita/ does not

[johnjamesjacoby]

(In [3233]) Fixes #2618 (1.2 branch) props mdawaffe

[johnjamesjacoby]

(In [3234]) Fixes #2618 (trunk) props mdawaffe

[johnjamesjacoby]

This is the only place where the username is directly referenced as a URI part.

If this crops up anywhere else (or needs to) we should reconsider putting this in as a filter and running it mandatory on every pass, since this function checks the DB directly against the value passed.

Fixed in branch and trunk.