Skip to:

Opened 14 years ago

Closed 14 years ago

#2583 closed defect (bug) (fixed)

[patch] bp_get_send_private_message_link() uses wrong filter

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.2.6 Priority: normal
Severity: Version:
Component: Messages Keywords: has-patch


In /bp-messages/bp-messages-templatetags.php, the bp_get_send_private_message_link() function applies the wrong filter.

It uses the same filter as the bp_get_send_public_message_link().

The attached patch fixes this.


I should also note that I've been experiencing some weird object caching issues with bp_core_get_username() and W3 Total Cache.

This made me look into the private message link filter so I could override bp_core_get_username() with the $bp global.

Might be part of a larger issue with bp_core_get_username() or it could be a W3 Total Cache problem. Thought I'd type this addendum!

Attachments (1)

2583.001.patch (882 bytes) - added by r-a-y 14 years ago.

Download all attachments as: .zip

Change History (6)

14 years ago

#1 @r-a-y
14 years ago

Forgot that Jeff had a patch similar to mine - #2566.

#2 @pisanojm
14 years ago

I posted awhile back about the object caching inw Total Cache causing issues with Private messaging. In particular when someone went to send a message after someone else sent a private message prior, the new private mesasage (by another user) would appear to be going to the "last" user that the private message was sent to... Is this what this patch fixes? If so, it would be awesome to turn object caching back on with Total Cache...

#3 @r-a-y
14 years ago

With the patch, you'd still need to apply a filter to "bp_get_send_private_message_link" and override it so it doesn't use bp_core_get_username().

The same problem occurs with the bp_get_send_public_message_link() function - aka the "Mention this user" link.

#4 @paulhastings0
14 years ago

  • Summary changed from bp_get_send_private_message_link() uses wrong filter to [patch] bp_get_send_private_message_link() uses wrong filter

#5 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3206]) Fixes #2583 props r-a-y

Note: See TracTickets for help on using tickets.