[patch] bp_get_send_private_message_link() uses wrong filter

[r-a-y]

In /bp-messages/bp-messages-templatetags.php, the bp_get_send_private_message_link() function applies the wrong filter.

It uses the same filter as the bp_get_send_public_message_link().

The attached patch fixes this.

---

I should also note that I've been experiencing some weird object caching issues with bp_core_get_username() and W3 Total Cache.

This made me look into the private message link filter so I could override bp_core_get_username() with the $bp global.

Might be part of a larger issue with bp_core_get_username() or it could be a W3 Total Cache problem. Thought I'd type this addendum!

[r-a-y]

Forgot that Jeff had a patch similar to mine - #2566.

[pisanojm]

I posted awhile back about the object caching inw Total Cache causing issues with Private messaging. In particular when someone went to send a message after someone else sent a private message prior, the new private mesasage (by another user) would appear to be going to the "last" user that the private message was sent to... Is this what this patch fixes? If so, it would be awesome to turn object caching back on with Total Cache...

[r-a-y]

With the patch, you'd still need to apply a filter to "bp_get_send_private_message_link" and override it so it doesn't use bp_core_get_username().

The same problem occurs with the bp_get_send_public_message_link() function - aka the "Mention this user" link.

[johnjamesjacoby]

(In [3206]) Fixes #2583 props r-a-y