Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 18 months ago

#2579 closed enhancement (maybelater)

Activity permalink router

Reported by: r-a-y Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.2
Component: Activity Keywords: needs-refresh, trac-tidy-2018
Cc:

Description

A user noted that activity permalinks redirect from:

example.com/activity/p/xxx

to

example.com/members/admin/activity/p/xxx

This is the case whether a group activity update is made as well.

---

Could the activity permalink stay the same without using the owner's user domain prefixed in the slug?

Or, what would be great is if activity permalinks could take the form of the component that is using it.

For example, if a group activity is posted, the group slug would form part of the activity permalink.

eg. example.com/groups/my-group/activity/p/xxx

Attachments (2)

2579.01.patch (9.8 KB) - added by r-a-y 8 years ago.
spanned.png (9.7 KB) - added by davidtcarson 8 years ago.
preview of what it looks like

Download all attachments as: .zip

Change History (14)

#1 @boonebgorges
9 years ago

  • Milestone changed from 1.3 to Awaiting Review

#2 @cnorris23
8 years ago

  • Keywords reporter-feedback added

I observed this too, but I believe it's been fixed in recent changes to trunk. I'll try to confirm later, unless r-a-y knows the status.

#3 @r-a-y
8 years ago

  • Keywords reporter-feedback removed
  • Version set to 1.3

This isn't fixed; some work was done but wasn't completed.

I have a patch coming in a bit.

#4 @r-a-y
8 years ago

  • Keywords has-patch added
  • Summary changed from Activity permalinks redirect to /username/activity/p/xxx to Activity permalink router

The attached patch finishes the job by routing group activities under the group permalink.

eg. example.com/activity/p/1/ is a group update

This now gets routed to:
example.com/groups/my-group/activity/1/

Includes new group activity permalink template. Could iterate this template to better show off the group. I basically copied permalink.php from /members/single/activity/

This patch will nullify #3210. Also read #3210 for info on why "show_hidden" is used.

Last edited 8 years ago by r-a-y (previous) (diff)

@r-a-y
8 years ago

#5 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to 1.3

#6 @DJPaul
8 years ago

  • Milestone changed from 1.3 to Future Release
  • Version changed from 1.3 to 1.2

In dev chat, we decided to put this into a future release -- possibly to review in 1.4 timescales -- as it's very late in the 1.3 cycle to add a new template file, which would encourage other component authors to route their activity items in the same way (not necessarily a bad thing), and duplicate the permalink.php for each component (a bad thing).

@davidtcarson
8 years ago

preview of what it looks like

#7 @DJPaul
6 years ago

  • Keywords has-patch removed
  • Severity set to normal

This still would be cool if someone wants to revitalise the patch.

#8 @boonebgorges
5 years ago

I'm a bit unclear on the purpose of the ticket. Is the goal to make URLs more semantic for better SEO? Or just because it's prettier? What's wrong with the activity/p/123 style?

#9 @r-a-y
5 years ago

  • Keywords needs-refresh added

Sorry for the late reply!

The original point was that the code for group activity permalink routing is actually in the codebase:
https://buddypress.trac.wordpress.org/browser/tags/2.0/bp-activity/bp-activity-actions.php#L71

But was never completed.

It's still a neat idea for group activity items to reside under the group URL rather than the user, but I'm wondering if there is any interest?

For some additional context, a long time ago, I was planning on doing a lightweight group bulletin board based off of the activity stream component. This ticket would have been useful so group activity permalinks get routed under a group's URL.

#10 @DJPaul
3 years ago

@r-a-y What do you think about this nowadays?

#11 @DJPaul
18 months ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#12 @DJPaul
18 months ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.