Skip to:

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2570 closed defect (bug) (fixed)

error in wp_list_comments callback to bp_dtheme_blog_comments_custom

Reported by: hnla's profile hnla Owned by:
Milestone: 1.2.6 Priority: normal
Severity: Version:
Component: Core Keywords:


The callback is made to a function residing in functions.php

The function spits out the main blog post comments/replies

From the WP codex [ ]

Note the lack of a trailing </li>. WordPress will add it itself once it's done listing any children and whatnot.

Now check the function and note the closing li tag!

Simple fix? can we remove that closing li tag please as it causes broken and invalid markup and can't be styled correctly and actually means nested/threaded comments have never actually worked out of the box !.

This is set deliberately at the 1.2.6 milestone as it's not out of the door yet and the solution should take around 0.0032ms to implement?

Change History (3)

#1 @DJPaul
14 years ago

You should know by now that the speed of patch isn't constant ;)

#2 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3159]) Fixes #2570 props hnla.

#3 @hnla
14 years ago

<i>You should know by now that the speed of patch isn't constant ;)</i>

I guess the universal constant is disrupted by dark matter :)

Odd sidenote: Received no notification of changes to this ticket, have to watch that.

Note: See TracTickets for help on using tickets.