Skip to:
Content

Opened 4 years ago

Closed 3 years ago

#2556 closed defect (bug) (fixed)

”Send To” Drop-down Box Error in ”Compose Message”

Reported by: leabdea Owned by:
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Messaging Keywords: has-patch needs-testing
Cc: herostrat

Description (last modified by DJPaul)

When I try to use the “Compose Message” page, I get an error in the drop-down box of the “Send To” field.

The drop down box displays things like
el=”alternate” type=”application/rss+xml” title=”Fan Club

Attachments (3)

BPcomposeError.jpg (24.2 KB) - added by leabdea 4 years ago.
screenshot of the dropdown box
2556.001.patch (652 bytes) - added by r-a-y 3 years ago.
2556.002.patch (646 bytes) - added by r-a-y 3 years ago.

Download all attachments as: .zip

Change History (11)

leabdea4 years ago

screenshot of the dropdown box

comment:1 r-a-y3 years ago

  • Keywords reporter-feedback added

Does this still occur in BP 1.2.6?
Have you tried this in other browsers?

r-a-y3 years ago

comment:2 r-a-y3 years ago

  • Keywords has-patch added; reporter-feedback removed
  • Version set to 1.3

comment:3 DJPaul3 years ago

  • Description modified (diff)
  • Keywords needs-testing added

I'm not sure this patch will work when WordPress is installed in a subdirectory; I think it will construct the wrong URL. I assume this is why SCRIPT_NAME is used here. We need to identify what the actual cause of this problem is. Does $_SERVERSCRIPT_NAME? not always contain "index.php"?

1.2 branch is awaiting release, we're not adding anything more to it.

comment:4 herostrat3 years ago

Just checked against a root and a subdomain install (WP 3.0.3):

Actually this patch is _necessary_ to make it work in a subdirectory. In a subdirectory install the current code constructs the URL like:

http://DOMAIN/SUBDOMAIN/SUBDOMAIN/wp-load.php

$bp->root_domain part:

http://DOMAIN/SUBDOMAIN/

str_replace( 'index.php', 'wp-load.php', $_SERVERSCRIPT_NAME? ) part:

SUBDOMAIN/wp-load.php

The proposed patch constructs the right path for root and subdirectory installs, so +1 for patching...

comment:5 herostrat3 years ago

  • Cc herostrat added

r-a-y3 years ago

comment:6 r-a-y3 years ago

Paul is right.

Just tested this with Wordpress installed in a subdirectory:
http://codex.wordpress.org/Giving_WordPress_Its_Own_Directory

And patch-001 doesn't address this.

Patch-002 should address this.

Tested where WP is installed in a subdirectory and on a network subdirectory install where BP_ROOT_BLOG = 2.

comment:7 DJPaul3 years ago

I really hate the way we inject javascript inline with messages_autocomplete_init_jsblock(); I think Boone said he was going to re-work the autocomplete javascript at some point, so I'll leave it to him to improve that.

comment:8 djpaul3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3533]) Fix message compose autocomplete when WP is installed in a subdirectory. Fixes #2556, props r-a-y.

Note: See TracTickets for help on using tickets.