Texts are not (properly) translated (bp-core-templatetags.php)

[helpy]

Hello,

Have a look at the lines ​926 and ​928 in ​bp-core-templatetags.php:

The german translation depending on the loaded page is:

+ “Members Verzeichnis” … instead of: “Mitgliederverzeichnis” (engl.: “Members Directory”)
+ “Groups Verzeichnis” … instead of: “Gruppenverzeichnis” (engl.: “Groups Directory”)

For a proper translation, you should think about changing the source code! In german language “Mitgliderverzeichnis” (Members Directory) is ONE word! Therefore with the present code line …

$title = sprintf( __( ‘%s Directory’, ‘buddypress’ ), ucwords( BP_MEMBERS_SLUG ) );

Besides the that the words "groups, members, ..." will not be translated, it ist not possible to translate it properly! It is the same with other directory pages!

cu, guido

[helpy]

Sorry! I thought that "milestone" is the version where I found this issue.

@developers ... please change it to whatever fits your plans!

[johnjamesjacoby]

This works for core components, but not for external root components like Events, etc...

Bumping to 1.3 because this function needs a sweep anyhow.

[GIGALinux]

I already had reported that bug and provided a patch that worked with plugins, too, but was marked as invalid :/ see #1364

[DJPaul]

We need to think about this again for BP 1.3. The components now exists as a Page in the posts table. We need to be pulling in those pages' name from the database to accomodate users who want to rename the pages via the wp-admin. This will unfortunately lead back to the two-word translation problem that this ticket and #1364 has highlighted.

Using "groups directory" as an example, as that phrase only appears on the page template itself and in the page title, what about just using "groups" in the title, i.e. dropping "... directory"? That'd take care of both issues.

[boonebgorges]

+1 on removing the word 'Directory' altogether.

[sorich87]

Removes "Directory"

[Bountin]

Some lines above there is a similar problem because $bp->current_component isn't gettext'd (see patch suggestion)

[DJPaul]

Closing this ticket in favour of #2595, as the two are effectively the same.

[djpaul]

(In [4194]) Improve page title i18n. Fixes #2595, #2555. Props for initial patches to SergeyBiryukov and sorich87.

Also fixes a couple of possible PHP notices.