Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

#2554 closed defect (bug) (fixed)

bp_is_activity_front_page() broken when BP used on secondary blog

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.2.6 Priority: normal
Severity: Version:
Component: Core Keywords: has-patch
Cc:

Description

If BP_ROOT_BLOG is set to anything other than 1, bp_is_activity_front_page() breaks.

The reason is bp_is_activity_front_page() utilizes bp_core_get_site_path(), which will always return "/" instead of checking the $current_blog->path.

The attached patch fixes this.

Attachments (1)

2554.001.patch (722 bytes) - added by r-a-y 12 years ago.

Download all attachments as: .zip

Change History (5)

@r-a-y
12 years ago

#1 @r-a-y
12 years ago

Actually, for subdomain network installs, bp_is_activity_front_page() should still work.

I meant to say for subdirectory installs, bp_is_activity_front_page() will break.

#2 @johnjamesjacoby
12 years ago

Can someone test this patch against a multi-site installation and a BP_ENABLE_MULTIBLOG situation also?

I can see there's an issue here, but I have a feeling that using bp_core_is_multisite() isn't always going to return the desired result.

#3 @r-a-y
12 years ago

Tested on a subdirectory multisite install with BP_ENABLE_MULTIBLOG set to true.

Works. Haven't looked too much into bp_core_is_multisite() though.

#4 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3160]) Fixes #2554.

Note: See TracTickets for help on using tickets.