Skip to:
Content

BuddyPress.org

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#2541 closed defect (bug) (fixed)

[patch] Link to Group Forum Directory Shouldn't Appear if Disabled [HAS-PATCH]

Reported by: crashutah Owned by:
Priority: normal Milestone: 1.5
Component: Forums Version:
Severity: Keywords:
Cc:

Description

If you have "Disable global forum directory?" set to "Yes" in the BP options, then it shouldn't display a link to the "Group Forum Directory" on line 19 of this file:
\buddypress\bp-themes\bp-default\groups\single\forum\topic.php

Seems like an easy patch if I knew how to call for that BP option.

Attachments (2)

2541.patch​ (1.7 KB ) - added by boonebgorges 16 years ago.
2541-1.patch​ (2.7 KB ) - added by boonebgorges 16 years ago.

Download all attachments as: .zip

Change History (11)

#1 @boonebgorges
16 years ago

  • Component Core → Forums

Good call, John.

@boonebgorges
16 years ago

#2 @boonebgorges
16 years ago

  • Keywords has-patch added
  • Summary Link to Group Forum Directory Shouldn't Appear if Disabled → Link to Group Forum Directory Shouldn't Appear if Disabled [HAS-PATCH]

#3 @paulhastings0
16 years ago

  • Summary Link to Group Forum Directory Shouldn't Appear if Disabled [HAS-PATCH] → [patch] Link to Group Forum Directory Shouldn't Appear if Disabled [HAS-PATCH]

#4 @r-a-y
16 years ago

  • Keywords commit added

Good catch! Any reason why this hasn't been committed?

#5 @DJPaul
16 years ago

  • Keywords has-patch commit removed

Unfortunately the patch is out of date and won't apply to trunk now that pages are used for the top level components.

#6 @DJPaul
16 years ago

To clarify: we'll need to take the "forums" page out of the main navigation menu as well as the links on the individual pages such as the ones addressed in this patch.

#7 @boonebgorges
16 years ago

2541-1.patch modifies tho main nav menu as well. I want feedback from DJPaul before committing, as bp-default's functions.php is more his baby than mine.

@boonebgorges
16 years ago

#8 @djpaul
16 years ago

  • Resolution → fixed
  • Status new → closed

(In [3631]) Hide forum directory from main nav if disabled by admin. Fixes #2541, props boonebgorges

#9 @DJPaul
16 years ago

I modified your patch slightly Boone, and change references throughout BP to use the new bp_forum_directory_is_disabled() function.

Note: See TracTickets for help on using tickets.