replace deprecated _c() with _x()

[cnorris23]

The function _c() was deprecated in WP 2.9. It's recommended replacement is _x(). This helps cut down on WP_DEBUG notices.

[cnorris23]

Related #1728

[johnjamesjacoby]

Can you review this one? I don't think that _c and _x are exactly alike. They output differently from what I can tell.

[r-a-y]

_c() - ​http://phpdoc.wordpress.org/trunk/WordPress/Deprecated/_wp-includes---deprecated.php.html#function_c
_x() - ​http://phpdoc.wordpress.org/trunk/WordPress/i18n/_wp-includes---l10n.php.html#function_x

According to the docs they output the same thing.

[cnorris23]

I just found the issue. Props to r-a-y for making me look at the docs a little harder this time. They output the same, but the parameters have changed. _x() accepts four parameters, while _c() only accepted two. The issue here is that the $domain parameter got bumped to slot three in _x(), rather than slot two as it was in _c(). Slot two for _x() now allows for a context for translators. I'll get the patch updated later tonight.

[cnorris23]

fixes parameter issues with previous patch

[cnorris23]

New patch should fix the output issues

[johnjamesjacoby]

Rock solid.

[johnjamesjacoby]

(In [3152]) Fixes #2524 props cnorris23