Settings Navigation Menu Missing

[jeffsayre]

With the recent improvements and fixes to BuddyPress' hook firing sequence ( see ​http://trac.buddypress.org/ticket/2325 ), the way in which navigation menu items are loaded was changed. Instead of the old way of hooking a menu item to the "wp" and "admin_menu" action hooks, an improved BP-specific method was created -- the "bp_setup_nav" action hook.

However, the hook to which the Settings navigation menu item is tied in bp-core-settings.php was not changed. bp_core_add_settings_nav() is still tied to the old two hooks. This results in the function not firing and means that the Settings navigation menu will not be displayed. See attached screenshots.

NOTE: It is important to make sure this change is made along with the changes in this Trac ticket ​http://trac.buddypress.org/ticket/2517

[jeffsayre]

Patch to bp_core_settings.php to make Settings navigation menu work

[jeffsayre]

Without patch, Settings menu does not appear

[jeffsayre]

With patch, Settings menu does appear

[intimez]

I do not see this problem and see settings menu for both wpms and wp.

[jeffsayre]

Alright, so I'm reducing this bug to normal based on above feedback. But, this is a bug for some people -- like me, for instance -- and we should make the change as all the other BP core navigation menu items are hooked to the "bp_setup_nav" action hook and not the "wp" and "admin_menu" action hooks. This will make it work for everyone.

[nuprn1]

Interesting

I had no issues with seeing Settings parent nav on BP1.2.5.2 - WP3.0/single before this patch. But I did have one problem where I was unable to add subnav items to 'Settings' but this fixed it.

so +1 for unintentional bug fix :-P

[hnla]

Confirming intimez's comment, but not arguing patch isn't required.

WP 3.0 MS BP 1.2.6 - Settings navigation items rendered ok

[pisanojm]

I can confirm that I can see SETTINGS without the patch... WP 3.0 BP 1.2.5.2/single. I can see as both an Admin and Subscriber. Also, not arguing that it doesn't fix hnla's comment.

[pisanojm]

Also, Adding/changing the code (1.2.5.2) to the patch... does not appear to affect the site adversely...

FYI

[johnjamesjacoby]

Can't duplicate this myself.

[johnjamesjacoby]

Moving to trivial because it can't be duplicated. Might get bumped to 1.3 unless we get some more action on this.

[r-a-y]

What about ​@nuprn1's comment, JJJ?

[johnjamesjacoby]

(In [3146]) Fixes #2521 props jeffsayre