Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#2515 closed enhancement (fixed)

[patch] LDAP username compability

Reported by: heliocorreia's profile heliocorreia Owned by: sorich87's profile sorich87
Milestone: 1.2.6 Priority: trivial
Severity: Version:
Component: Activity Keywords: has-patch
Cc:

Description

LDAP accounts have username like: name.surname[at]domain.tdl

To support that on @mentions feature, can the username pattern change, by adding a dot as an allowed char?
From: /[@]+([A-Za-z0-9-_]+)/
To: /[@]+([A-Za-z0-9-_\.]+)/

Files: /trunk @rev 2722

  • bp-activity-filters.php (line 96)
  • bp-activity-notifications.php (line 7)

Is that a problem?

Attachments (1)

2515.patch (1.6 KB) - added by sorich87 14 years ago.

Download all attachments as: .zip

Change History (10)

#1 @heliocorreia
14 years ago

  • Priority changed from normal to trivial

@sorich87
14 years ago

#2 @sorich87
14 years ago

  • Keywords has-patch added; ldap mention removed
  • Owner set to sorich87
  • Status changed from new to accepted

#3 @paulhastings0
14 years ago

  • Summary changed from LDAP username compability to [patch] LDAP username compability

#4 @pisanojm
14 years ago

Nothing really to test with this change...

#5 @johnjamesjacoby
14 years ago

Don't currently have an LDAP installation to test this on. If anyone does, and can confirm for me that this fixes their issue, we'll get it in for 1.2.6.

#6 follow-up: @heliocorreia
14 years ago

johnjamesjacoby, it worked for me.

#7 in reply to: ↑ 6 ; follow-up: @paulhastings0
14 years ago

Replying to heliocorreia:

johnjamesjacoby, it worked for me.

heliocorreia, You mean the patch works or that you didn't even experience a problem to begin with?

#8 in reply to: ↑ 7 @heliocorreia
14 years ago

Replying to paulhastings0:

heliocorreia, You mean the patch works or that you didn't even experience a problem to begin with?

paulhastings0, the patch works with my LDAP/BuddyPress enviroment.

#9 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [3223]) Better LDAP support. Fixes #2515. Props sorich87.

Note: See TracTickets for help on using tickets.