Skip to:

Opened 14 years ago

Closed 14 years ago

#2495 closed enhancement (fixed)

Unnecessary wpautop filter on "bp_get_message_thread_subject" causing invalid html

Reported by: sbrajesh's profile sbrajesh Owned by:
Milestone: 1.2.6 Priority: normal
Severity: Version:
Component: Messages Keywords: has-patch
Cc: sbrajesh


Do we really need a wpautop filter on message subjects and notice subjects.

The use of "wpautop" filter on message/notice subject is un necessary as we do not expect message sunject to be produced as paragraph or do we ? And another reason, we need to remove it because it produces incvalid html when we link subject to the message as in

<a href="<?php bp_message_thread_view_link() ?>" title="<?php _e( "View Message", "buddypress" ); ?>"><?php bp_message_thread_subject() ?></a>

That will produce invalid html(p inside a).

here is a patch attached.

Attachments (1)

bp-messages-filters.patch (755 bytes) - added by sbrajesh 14 years ago.

Download all attachments as: .zip

Change History (4)

#1 @sbrajesh
14 years ago

  • Cc sbrajesh added
  • Type changed from defect to enhancement

#2 @r-a-y
14 years ago

  • Keywords has-patch added; bp_get_message_thread_subject removed

#3 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3177]) Fixes #2495 props sbrajesh

Note: See TracTickets for help on using tickets.