Skip to:
Content

Opened 4 years ago

Closed 4 years ago

#2472 closed enhancement (fixed)

[patch] Paging also for the bottom-pages

Reported by: erich73 Owned by: sorich87
Milestone: 1.2.6 Priority: normal
Severity: Version:
Component: Core Keywords: has-patch
Cc: paulhastings0@…

Description

@JJJ

can you drop-in the "Paging-numbering" also into the bottom of the page ?
For Groups-page and Members-page ?

This would help in terms of User-Interface.

Many thanks,

Attachments (2)

functions.php (1.4 KB) - added by paulhastings0 4 years ago.
functions.php file that creates page-numbering at the bottom of the Groups, Members, and Blogs directories.
2472.patch (3.9 KB) - added by sorich87 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 johnjamesjacoby4 years ago

I thought about it, but the pagination on the bottom of each page is actually non-standard, as it repeats object ID's.

This is on my list of things to do though, and now there's a ticket to remind me. :)

paulhastings04 years ago

functions.php file that creates page-numbering at the bottom of the Groups, Members, and Blogs directories.

comment:2 paulhastings04 years ago

If it helps any I've attached the code in my functions.php file that adds page-numbering to the bottom of the Groups, Members, and Blogs directories. It might give you some ideas how to implement the page-numbering into the core.

I believe the original code came from @dwenaus, so kudos to him. :)

comment:3 paulhastings04 years ago

  • Cc paulhastings0@… added

sorich874 years ago

comment:4 sorich874 years ago

  • Keywords has-patch added
  • Owner set to sorich87
  • Status changed from new to accepted

Here is a patch.

After looking at the pagination functions, I think there should be only two functions (bp_pagination_count() and bp_pagination_links()?) whatever the component. The current functions (e.g.: bp_blogs_pagination_count(), bp_forum_pagination_count(), bp_groups_pagination_count(), bp_members_pagination_count()) can be merged because they are too similar.

comment:5 pisanojm4 years ago

I jus tested this based on 2472 patch and it looks great. And quite useful. Works on 1.2.5.2 WP 3.0.1 Only note: #pag-above is not defined in the CSS and is called for in the patch change... doesn't make a difference though as far as look. Just FYI>

comment:6 paulhastings04 years ago

  • Summary changed from Paging also for the bottom-pages to [has patch] Paging also for the bottom-pages

comment:7 paulhastings04 years ago

  • Summary changed from [has patch] Paging also for the bottom-pages to [patch] Paging also for the bottom-pages

comment:8 johnjamesjacoby4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [3222]) Normalize loop template files. Add bottom pagination. Fixes #2472. Props sorich87.

Note: See TracTickets for help on using tickets.