Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#2470 closed defect (bug) (fixed)

BP_AVATAR_DEFAULT not used in bp-core-avatars.php

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.2.5 Priority: normal
Severity: Version:
Component: Core Keywords: has-patch, avatar
Cc:

Description

In bp-core-avatars.php, BP_AVATAR_DEFAULT is defined, but not used.

BP_AVATAR_DEFAULT should be used on the "bp_core_mysteryman_src" filter.

Also, for the "bp_core_mysteryman_src" filter, we need to pass the $grav_size as well.

In the provided patch, I wasn't sure what to make of BP_AVATAR_DEFAULT_THUMB, so I just defined it with a currently, non-existing 50x50 version of our good pal, the mystery man.

Attachments (1)

2470.001.patch​ (1.6 KB) - added by r-a-y 14 years ago.

Download all attachments as: .zip

Change History (4)

@r-a-y
14 years ago

#1 @r-a-y
14 years ago

The alternative is to remove both the BP_AVATAR_DEFAULT and BP_AVATAR_DEFAULT_THUMB defines, but keep the existing "bp_core_mysteryman_src" filter with the additional $grav_size parameter as noted in the patch.

#2 @johnjamesjacoby
14 years ago

Good catch r-a-y!

#3 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3081]) Fixes #2470 props r-a-y

Note: See TracTickets for help on using tickets.