Opened 14 years ago
Closed 14 years ago
#2461 closed defect (bug) (fixed)
Undefined and useless property called in edit forum post link generation
Reported by: | francescolaffi | Owned by: | |
---|---|---|---|
Milestone: | 1.2.5 | Priority: | minor |
Severity: | Version: | ||
Component: | Forums | Keywords: | dev-feedback has-patch |
Cc: | francescolaffi |
Description
tiny harmless defect, but it still deserves to be solved
bp-forums-templatetags.php:960 [...] wp_nonce_url( bp_get_the_topic_permalink() . $topic_template->post->id . 'edit/post/' . $topic_template->post->post_id . '/' . $query_vars, 'bp_forums_edit_post' ) [...]
the $topic_template->post->id
in the link is undefined and does nothing except generating a notice, actually if it was defined the link would be invalid, I guess it's only a copy/paste inattention.
diff is for b1.2, same problem in the trunk but the line is 927 instead of 960
Attachments (1)
Change History (2)
Note: See
TracTickets for help on using
tickets.
(In [3083]) Fixes #2461 props francescolaffi