Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2459 closed defect (bug) (fixed)

group name slash

Reported by: intimez's profile intimez Owned by:
Milestone: 1.2.5 Priority: normal
Severity: Version:
Component: Forums Keywords: has-patch
Cc:

Description

Create a new group: John's Guest
Post forum topic in John's Guest
Look under Posted In Group and John's Guest shows up as John\'s Guest

[wordpress3+buddypress1.2.4.1]

Attachments (1)

2459.001.diff (583 bytes) - added by cnorris23 14 years ago.

Download all attachments as: .zip

Change History (9)

#1 @cnorris23
14 years ago

  • Component changed from Core to Forums
  • Keywords has-patch added; group name slash removed

Add stripslashes_deep filter

@cnorris23
14 years ago

#2 @intimez
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Applied patch and slash is now removed. Thanks @cnorris23

#3 @cnorris23
14 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This ticket actually needs to stay open, so that one of the core devs can commit it to the official BP code. This way it's fixed for everyone.

#4 @intimez
14 years ago

@cnorris23

Sorry about that. Thought I would help clear open ticket after confirming. One less ticket for 1.2.5 either way.

#5 @cnorris23
14 years ago

Right, but that's not how Trac works. If the ticket is closed, it will get overlooked by the devs, because it has been marked as fixed, invalid, wontfix, etc. If the ticket is overlooked, the devs won't know there's a real issue that needs to be addressed in core, they won't be able to look for a fix, or apply a fix that's already been added to the ticket. What this means for you... When 1.2.5 comes out the patch you just applied will be wiped out. You will start seeing slashes in the group names again. If the issue bothers you enough, you will then have to manually patch the file again. This will continue into perpetuity until someone else submits a ticket, or a dev notices it, and it is fixed. Bottom line, if you submit a ticket and a solution is presented, test that solution. If the solution works, post a comment saying so, but leave the ticket open so that the issue/fix can be applied to the plugin code.

#6 @johnjamesjacoby
14 years ago

Thanks guys for this.

@intimez No worries; now you know :)

#7 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3072]) Fixes #2459 props cnorris23

#8 @cnorris23
14 years ago

@intimez
What jjj said. If I came off as a jerk, just know that was the last thing on my mind. Just letting you know what was going on. It was only after I posted it that I realized how long it was. In conclusion, I'm sorry. "No worries; now you know :)" ;)

Note: See TracTickets for help on using tickets.