bb-config creator should use single quotes for salt strings

[francescolaffi]

right now it writes the bb-config file with salts in double quotes, that is bad because salts are random strings and can have $ in them, so they should not be interpreted

i.e. from my local testing installation

define('BB_AUTH_SALT', "^Dola{t1!k,RaEnLXq$h[C?b}.)~6YWl ]#(d|j+99IZZYhLPmQ:M%UGn_V8-8}@");

and I get a PHP Parse error: syntax error, unexpected '?', expecting ']' because of the $h[C? in the salt

attached diff fix it in 1.2 branch but the same solution is valid in trunk, it only changes change double quotes to single quotes around not to be interpreted strings

[cnorris23]

Tested and it works. Good catch.

[DJPaul]

Unfortunately this is not a BuddyPress bug. The path affects a BBPress file, which BuddyPress merely bundles with its distribution. You need to post this on the BBPress trac

[francescolaffi]

Replying to DJPaul:

Unfortunately this is not a BuddyPress bug. The path affects a BBPress file, which BuddyPress merely bundles with its distribution. You need to post this on the BBPress trac

ehm not really, actually the bb-config generation is done by buddypress, if you look the diff you'll see it only changes bp-forums-admin.php that is an actual buddypress file, not a bbpress one included with svn:externals

[johnjamesjacoby]

Confirmed. Got this error once about 8months ago and didn't have time to investigate. Will commit patch when at my computer next.

[johnjamesjacoby]

(In [3073]) Fixes #2455 props francescolaffi