Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 13 years ago

#2420 closed defect (bug) (fixed)

activity unable to display text within bracket

Reported by: intimez's profile intimez Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords: activity, stream, comment, bracket
Cc:

Description

Leaving a comment inside a bracket will not show up in the activity stream of buddypress.

wordpress comment shows: this is a test comment for [testing123]
buddypress activity shows: this is a test comment for

[wordpress2.9.2+buddypress1.2.4.1]

Attachments (1)

2420-1.diff (642 bytes) - added by boonebgorges 14 years ago.

Download all attachments as: .zip

Change History (8)

#1 @johnjamesjacoby
14 years ago

  • Milestone changed from 1.2.5 to 1.3

Bumping to 1.3. There's a do_shortcode conflict somewhere, but with all the filters involved I don't want to go messing with them in a point release.

#2 @boonebgorges
14 years ago

2420-1.diff changes the way that the excerpt is created. The problem with this solution is that it will allow shortcodes to be processed, which could cause a number of issues (with formatting, with unclosed tags in the case of multi-part shortcodes, etc). Anyone have thoughts?

@boonebgorges
14 years ago

#3 follow-up: @DJPaul
13 years ago

Certainly can't let regular users embed shortcodes into activity stream items.

#4 in reply to: ↑ 3 @r-a-y
13 years ago

Bug appears to occur with indirect activity entries only -- blog post, blog comment, forum post. Not activity status updates or comments.

Tested on a forum thread on testbp.org.

Replying to DJPaul:

Certainly can't let regular users embed shortcodes into activity stream items.

Going slightly off-topic, but I definitely see benefits to using some shortcodes.

#5 @DJPaul
13 years ago

Shortcodes in activity stream items are already supported on the permalink pages, but not in the activity stream excerpts (yet? see #2707).

#6 @DJPaul
13 years ago

I'm about to commit a change to the shortcode stripping function to strip only registered shortcodes from the excerpts. This way, any text in square brackets which was not intended to be a shortcode reference will still show up.

#7 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4356]) Change bp_create_excerpt to use a WP core function for stripping registered shortcodes. Fixes #2420

Note: See TracTickets for help on using tickets.