Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#2409 closed defect (bug) (fixed)

bp_user_link & bp_displayed_user_link returns bp_get_loggedin_user_link

Reported by: nuprn1 Owned by:
Milestone: 1.2.5 Priority: normal
Severity: Version:
Component: Core Keywords:
Cc:

Description

bp_user_link returns bp_get_loggedin_user_link which is linking the username on a displayed profile back to the logged in user. Previously it would link to the actual displayed user.

function bp_displayed_user_link() {
	echo bp_get_loggedin_user_link();
}
function bp_user_link() { bp_displayed_user_link(); }

Change History (9)

#2 @r-a-y
10 years ago

Good catch!

I think bp_user_link() should be like this:

function bp_user_link() {
	echo bp_displayed_user_link();
}

#3 @nuprn1
10 years ago

i see the diff now in member-header.php with 1.2.3 but it seems the avatar is still wrapped

<div id="item-header-avatar">
	<a href="<?php bp_user_link() ?>">
		<?php bp_displayed_user_avatar( 'type=full' ) ?>
	</a>
</div><!-- #item-header-avatar -->

vs

<a href="<?php bp_displayed_user_link() ?>"><?php bp_displayed_user_fullname() ?></a>

#4 @r-a-y
10 years ago

Yup! bp_displayed_user_link() also needs to be changed to:

function bp_displayed_user_link() {
	echo bp_get_displayed_user_link();
}

#5 @r-a-y
10 years ago

Dunno why there are two functions for the same thing:
bp_user_link() and bp_displayed_user_link()

#6 @johnjamesjacoby
10 years ago

  • Milestone changed from 1.3 to 1.2.5

#7 @apeatling
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3022]) Fixing mix up with logged in and displayed user link functions. Fixes #2409

#8 @erich73
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry to re-open this ticket, just wanted to double-check with you whether the strings in the text (I mean the text which pops-up when you click on the blue-colored "Questionmark") has been corrected as well ?

I am talking abut the text (see below), which also shows logged-in-username instead of the name of the Persons-Profile:

*

@peter is a unique identifier for admin that you can type into any message on this site. admin will be sent a notification and a link to your message any time you use it.

*

Many thanks,

Erich

#9 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This has been fixed and is unrelated to this ticket.

Note: See TracTickets for help on using tickets.